Repository navigation
docs: name the app-side service token SEAMLESS_SERVICE_TOKEN - #6
Merged
Merged
Conversation
The reference apps are app-side, so they read the service token from SEAMLESS_SERVICE_TOKEN. The auth API in the conformance stack still reads API_SERVICE_TOKEN with the same value.
The examples read the service token from SEAMLESS_SERVICE_TOKEN. The auth server keeps reading API_SERVICE_TOKEN; both hold the same value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The app-side service token env var is now
SEAMLESS_SERVICE_TOKEN. The auth API server still readsAPI_SERVICE_TOKEN; both hold the same value.SEAMLESS_SERVICE_TOKEN(wasSERVICE_SECRET/API_SERVICE_TOKEN), with one sentence explaining the two names.SEAMLESS_SERVICE_TOKEN.conformance/_shared.py) and their CI step readSEAMLESS_SERVICE_TOKEN. The conformance stack's auth API container is configured by seamless-cli and still usesAPI_SERVICE_TOKENwith the same value.The adapter reads no environment variables itself; these are app-side example and fixture names only.
Checks
uv run ruff check .,uv run ruff format --check .,uv run mypy,uv run pytestpass.